The pros are you don't have to reinstall any software
already installed. The cons are that any problems you are
having with windows 2000 you'll most likely have with XP.
Bet thing is to wipe the plate clean and start from
scratch. I've always found upgrading a pain and having to
reinstall from scratch later anyways cause of weird
problems the upgrade causes.