Using Queue with multiple class objects

  • Thread starter Thread starter Anders Eriksson
  • Start date Start date
A

Anders Eriksson

I need to have a Queue that contains a number of commands[1]. There are
three different command types and I wonder if this is the way to do this
or if there is a smarter way?

I have created an abstract class that has the type of command.
Then I created three subclasses that sets the type and adds the specific
properties for this command. See code below.

adding to queue
QDocCmd dCmd = new QDocCmd();
dCmd.InternalFileName = "doc.xlp";
dCmd.Linked = false;
_cmdQueue.Enqueue(dCmd);

extract from queue
foreach (QCommand qc in _cmdQueue)
{
if (qc.QType == CmdType.Document)
{
QDocCmd cmd = (QDocCmd)qc;
...
}
...
}

// Anders
[1] The commands are function calls to a hardware device.

namespace MyCommands
{
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
public enum CmdType
{
Tilt,
Move,
Document
}
/// <summary>
/// Class for Command data in queue
/// </summary>
public abstract class QCommand
{
public CmdType QType { get; set; }
abstract public bool Run();
}
public class QDocCmd : QCommand
{
public QDocCmd()
{
QType = CmdType.Document;
}
public string InternalFileName { get; set; }
public bool Linked { get; set; }

override public bool Run()
{
bool result = true;

result = DoDocument();

return result;
}
}
public class QMoveCmd : QCommand
{
public QMoveCmd()
{
QType = CmdType.Move;
}
public double R { get; set; }
public double X { get; set; }
public double Y { get; set; }
public double Z { get; set; }

override public bool Run()
{
bool result = true;

result = DoMove();

return result;
}

}
public class QTiltCmd : QCommand
{
public QTiltCmd()
{
QType = CmdType.Tilt;
}
public double Angle { get; set; }

override public bool Run()
{
bool result = true;

result = DoTilt();

return result;
}

}
}
 
I need to have a Queue that contains a number of commands[1]. There are
three different command types and I wonder if this is the way to do this
or if there is a smarter way?

I have created an abstract class that has the type of command.
Then I created three subclasses that sets the type and adds the specific
properties for this command. See code below.

adding to queue
QDocCmd dCmd = new QDocCmd();
dCmd.InternalFileName = "doc.xlp";
dCmd.Linked = false;
_cmdQueue.Enqueue(dCmd);

extract from queue
foreach (QCommand qc in _cmdQueue)
{
if (qc.QType == CmdType.Document)
{
QDocCmd cmd = (QDocCmd)qc;
...
}
...
}

// Anders
[1] The commands are function calls to a hardware device.

namespace MyCommands
{
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
public enum CmdType
{
Tilt,
Move,
Document
}
/// <summary>
/// Class for Command data in queue
/// </summary>
public abstract class QCommand
{
public CmdType QType { get; set; }
abstract public bool Run();
}
public class QDocCmd : QCommand
{
public QDocCmd()
{
QType = CmdType.Document;
}
public string InternalFileName { get; set; }
public bool Linked { get; set; }

override public bool Run()
{
bool result = true;

result = DoDocument();

return result;
}
}
Click to expand...

This is actual relative close to the well known GoF
Command Pattern.

You should just drop the QType.

foreach (QCommand qc in _cmdQueue)
{
bool result = qc.Run();
}

public abstract class QCommand
{
abstract public bool Run();
}

public class QDocCmd : QCommand
{
public string InternalFileName { get; set; }
public bool Linked { get; set; }
override public bool Run()
{
bool result = DoDocument();
return result;
}
}

Arne
 
This is actual relative close to the well known GoF
Command Pattern.
Click to expand...
I have to look this up!
You should just drop the QType.

foreach (QCommand qc in _cmdQueue)
{
bool result = qc.Run();
}

public abstract class QCommand
{
abstract public bool Run();
}

public class QDocCmd : QCommand
{
public string InternalFileName { get; set; }
public bool Linked { get; set; }
override public bool Run()
{
bool result = DoDocument();
return result;
}
}
Click to expand...
Aha! So the compiler already knows which type of command it is! Neat!
That solves some other problem I have in another program...
Arne
Click to expand...
Thank you very much Arne! For this answer and all the others you give. I
learn something new everytime!

// Anders
 
I have to look this up!
Yep.

Aha! So the compiler already knows which type of command it is! Neat!
That solves some other problem I have in another program...
Click to expand...

That is how polymorphism works!

Arne
 
Back
Top