Testing for required data entry in form fields.

  • Thread starter Thread starter Gina
  • Start date Start date
G

Gina

On my form, there are 2 combo boxes and a few other bound text boxes.
All have been tagged as "Required". I want to test that all the form
fields have been entered before the form is closed.

The user selects a value in combo 1. In the afterupdate event of combo
1, combo 2 is requeried to narrow down the selections available. The
user is then required to make a selection from combo 2.

On the close button I have this code to check that all the fields on
the form have been entered.

If Me.Dirty Then
For Each ctl In Me
If ctl.Tag = "Required" And IsNull(ctl) Then
MsgBox ctl.Name & " must be entered."
ctl.SetFocus
Exit Sub
End If
Next ctl
End If

This code works for all the fields except combo 2. The form will
close with no error message if all fields have been populated but
combo 2 is left blank.


I am stumped as to why this should happen. Can anyone help?
 
On my form, there are 2 combo boxes and a few other bound text boxes.
All have been tagged as "Required". I want to test that all the form
fields have been entered before the form is closed.

The user selects a value in combo 1. In the afterupdate event of combo
1, combo 2 is requeried to narrow down the selections available. The
user is then required to make a selection from combo 2.

On the close button I have this code to check that all the fields on
the form have been entered.

If Me.Dirty Then
For Each ctl In Me
If ctl.Tag = "Required" And IsNull(ctl) Then
MsgBox ctl.Name & " must be entered."
ctl.SetFocus
Exit Sub
End If
Next ctl
End If

This code works for all the fields except combo 2. The form will
close with no error message if all fields have been populated but
combo 2 is left blank.


I am stumped as to why this should happen. Can anyone help?
Click to expand...

Sounds like the Required tag is not set on combo2. If you put a breakpoint on
the code at the line If ctl.Tag = "Required", you should be able to step
through the code until combo2 is reached, and check its Tag property (and its
value).

If the control could contain a zero length string, it would be a bit safer to
test

.... And Len(ctl & "") = 0

instead of IsNull(ctl).
--

John W. Vinson [MVP]
Microsoft's replacements for these newsgroups:
http://social.msdn.microsoft.com/Forums/en-US/accessdev/
http://social.answers.microsoft.com/Forums/en-US/addbuz/
and see also http://www.utteraccess.com
 
Sounds like the Required tag is not set on combo2. If you put a breakpoint on
the code at the line If ctl.Tag = "Required", you should be able to step
through the code until combo2 is reached, and check its Tag property (andits
value).

If the control could contain a zero length string, it would be a bit safer to
test

... And Len(ctl & "") = 0

instead of IsNull(ctl).
--

             John W. Vinson [MVP]
 Microsoft's replacements for these newsgroups:
 http://social.msdn.microsoft.com/Forums/en-US/accessdev/
 http://social.answers.microsoft.com/Forums/en-US/addbuz/
 and see alsohttp://www.utteraccess.com- Hide quoted text -

- Show quoted text -
Click to expand...

Thanks for your response John. All the fields are correctly tagged.
Changing the code as you suggest to:

If ctl.Tag = "Required" And Len(ctl & "") = 0

produces an error message "Object doesn't support this property or
method".

Still stumped. Interestingly, if I change combo 2 to an unbound
control (which I don't want), the tag property DOES work. Does that
suggest anything?
 
Thanks for your response John. All the fields are correctly tagged.
Changing the code as you suggest to:

If ctl.Tag = "Required" And Len(ctl & "") = 0

produces an error message "Object doesn't support this property or
method".

Still stumped. Interestingly, if I change combo 2 to an unbound
control (which I don't want), the tag property DOES work. Does that
suggest anything?
Click to expand...

Try Len(ctl.Value & "") instead - I guess the control as a variable doesn't
default the same way as the control object itself.

What are the combo box's RowSource and ControlSource? If you step through your
previous code in debug mode, what is the value of ctl when it reaches that
combo?
--

John W. Vinson [MVP]
Microsoft's replacements for these newsgroups:
http://social.msdn.microsoft.com/Forums/en-US/accessdev/
http://social.answers.microsoft.com/Forums/en-US/addbuz/
and see also http://www.utteraccess.com
 
Try Len(ctl.Value & "") instead - I guess the control as a variable doesn't
default the same way as the control object itself.

What are the combo box's RowSource and ControlSource? If you step throughyour
previous code in debug mode, what is the value of ctl when it reaches that
combo?
--

             John W. Vinson [MVP]
 Microsoft's replacements for these newsgroups:
 http://social.msdn.microsoft.com/Forums/en-US/accessdev/
 http://social.answers.microsoft.com/Forums/en-US/addbuz/
 and see alsohttp://www.utteraccess.com
Click to expand...

Nope - makes no difference adding the .value.

Not too familiar with debugging mode. Run to cursor? Place a
breakpoint. Can't get it to step through - keeps saying there is no
"executable statement".

Here's the design of the 2 combos if that helps.

combo1 unbound (cboCourseType)

combo1 row source:
SELECT lkpTrainingType.fldTrainingTypeID,
lkpTrainingType.fldTrainingTypeDescription
FROM lkpTrainingType;



combo 2 (cboCourseTitle) control source:
fldCourseID


combo2 row source:

SELECT tblTrainingCourses.fldCourseID,
tblTrainingCourses.fldCourseDescription, tblTrainingCourses.fldTypeID
FROM tblTrainingCourses
WHERE (((tblTrainingCourses.fldTypeID)=[Forms].
[frmCreateTrainingSession]![cboCourseType]))
ORDER BY tblTrainingCourses.fldCourseDescription;


after update combo1:
Me!cboCourseTitle.Enabled = True
Me!cboCourseTitle.requery
 
Gina, were you ever able to get this working?

Try Len(ctl.Value & "") instead - I guess the control as a variable doesn't
default the same way as the control object itself.

What are the combo box's RowSource and ControlSource? If you step through your
previous code in debug mode, what is the value of ctl when it reaches that
combo?
--

             John W. Vinson [MVP]
 Microsoft's replacements for these newsgroups:
 http://social.msdn.microsoft.com/Forums/en-US/accessdev/
 http://social.answers.microsoft.com/Forums/en-US/addbuz/
 and see alsohttp://www.utteraccess.com
Click to expand...

Nope - makes no difference adding the .value.

Not too familiar with debugging mode. Run to cursor? Place a
breakpoint. Can't get it to step through - keeps saying there is no
"executable statement".

Here's the design of the 2 combos if that helps.

combo1 unbound (cboCourseType)

combo1 row source:
SELECT lkpTrainingType.fldTrainingTypeID,
lkpTrainingType.fldTrainingTypeDescription
FROM lkpTrainingType;



combo 2 (cboCourseTitle) control source:
fldCourseID


combo2 row source:

SELECT tblTrainingCourses.fldCourseID,
tblTrainingCourses.fldCourseDescription, tblTrainingCourses.fldTypeID
FROM tblTrainingCourses
WHERE (((tblTrainingCourses.fldTypeID)=[Forms].
[frmCreateTrainingSession]![cboCourseType]))
ORDER BY tblTrainingCourses.fldCourseDescription;


after update combo1:
Me!cboCourseTitle.Enabled = True
Me!cboCourseTitle.requery
Click to expand...
--

John W. Vinson [MVP]
Microsoft's replacements for these newsgroups:
http://social.msdn.microsoft.com/Forums/en-US/accessdev/
http://social.answers.microsoft.com/Forums/en-US/addbuz/
and see also http://www.utteraccess.com
 
Gina, were you ever able to get this working?




Nope - makes no difference adding the .value.
Click to expand...
Not too familiar with debugging mode.  Run to cursor? Place a
breakpoint. Can't get it to step through - keeps saying there is no
"executable statement".
Click to expand...
Here's the design of the 2 combos if that helps.
Click to expand...
combo1 unbound (cboCourseType)
Click to expand...
combo1 row source:
SELECT lkpTrainingType.fldTrainingTypeID,
lkpTrainingType.fldTrainingTypeDescription
FROM lkpTrainingType;
Click to expand...
combo 2 (cboCourseTitle) control source:
fldCourseID
Click to expand...
combo2 row source:
Click to expand...
SELECT tblTrainingCourses.fldCourseID,
tblTrainingCourses.fldCourseDescription, tblTrainingCourses.fldTypeID
FROM tblTrainingCourses
WHERE (((tblTrainingCourses.fldTypeID)=[Forms].
[frmCreateTrainingSession]![cboCourseType]))
ORDER BY tblTrainingCourses.fldCourseDescription;
Click to expand...
after update combo1:
Me!cboCourseTitle.Enabled = True
Me!cboCourseTitle.requery
Click to expand...

--

             John W. Vinson [MVP]
 Microsoft's replacements for these newsgroups:
 http://social.msdn.microsoft.com/Forums/en-US/accessdev/
 http://social.answers.microsoft.com/Forums/en-US/addbuz/
 and see alsohttp://www.utteraccess.com- Hide quoted text -

- Show quoted text -
Click to expand...

Hi John,

There you are! I thought you had forgotten me:-) Today is the first
time I have seen your last post. For some reason, my view of this
group has not been updating.

No, my problem is still there - and my last post above is still the
current position.

Gina.
 
Back
Top