Profundal insight #354: switch statement needs dummy assignment tocompile

  • Thread starter Thread starter RayLopez99
  • Start date Start date
R

RayLopez99

Notice the dummy assignment is needed below.

No I'm NOT a dummy.

Just pointing out a quirk in C#

RL

foreach (char x in myCharArray)

{

Char1 = 'Z'; //dummy assignment

if (Char.IsDigit(x)) Char1 = 'A';
if (Char.IsLetter(x)) Char1 = 'B';

switch (Char1)
{
case 'A':
{
break;
}
case 'B':
{
break;
}
default:
break;
}

}
 
RayLopez99 said:
Notice the dummy assignment is needed below.

No I'm NOT a dummy.

Just pointing out a quirk in C#

RL

foreach (char x in myCharArray)

{

Char1 = 'Z'; //dummy assignment

if (Char.IsDigit(x)) Char1 = 'A';
if (Char.IsLetter(x)) Char1 = 'B';

switch (Char1)
{
case 'A':
{
break;
}
case 'B':
{
break;
}
default:
break;
}

}
Click to expand...

Of course you need to assign a value to the variable. The compiler
doesn't let you use a variable which possibly is unassigned.'

In this case it saves you from a bug in your code. If the variable would
be initialized when you enter the method (like it is in VB), so that you
didn't need to initialise it, it would keep it's value from one
iteration to the next in the loop. If you have a letter followed by
characters that are neither a digit or a letter, those character would
also be considered as letters.
 
Oh, and of course it has nothing at all to do with the switch statement.
Click to expand...

I doubt it Goran, but thanks for your answer. You can have an
unassigned variable int jay; for example, last I checked (let me check
now... yes, you just get a warning: "variable 'jay' is declared but
never used" but it compiles).

RL
 
RayLopez99 said:
I doubt it Goran, but thanks for your answer. You can have an
unassigned variable int jay; for example, last I checked (let me check
now... yes, you just get a warning: "variable 'jay' is declared but
never used" but it compiles).
Click to expand...

It compiles only if you never read from it.

If you read from a variable that is potentially unassigned, you get a
compile error. Potentially unassigned simply means the compiler couldn't
guarantee it was written to already, its rules for this aren't perfect. But
it doesn't matter whether you use switch, if, add the variable to something
else, or so on. Anything that reads the variable will cause the error.
 
If you read from a variable that is potentially unassigned, you get a
compile error.  Potentially unassigned simply means the compiler couldn't
guarantee it was written to already, its rules for this aren't perfect.
Click to expand...

I think the key is it depends on what level your compiler warnings are
set. Mine are at "default" (whatever that is) and like I said in the
OP for case/switch it fails to compile, but for a regular int
declaration it just gives a warning.

Thanks for your input.

RL
 
RayLopez99 expressed precisely :
I think the key is it depends on what level your compiler warnings are
set. Mine are at "default" (whatever that is) and like I said in the
OP for case/switch it fails to compile, but for a regular int
declaration it just gives a warning.

Thanks for your input.

RL
Click to expand...

Let's try to explain with some examples:


Try changing your code to

foreach (char x in myCharArray)
{
char Char1;
// Char1 = 'Z'; forget the dummy assignment

if (Char.IsDigit(x)) Char1 = 'A';
else if (Char.IsLetter(x)) Char1 = 'B'; // "else if"
else Char1 = 'Z'; // extra "else"

switch (Char1)
{
case 'A':
{
break;
}
case 'B':
{
break;
}
default:
break;
}
}

This will compile (and execute correctly), as Char1 is definitely
assigned by the time you hit the switch.


Or try this:

string s = "";
foreach (char x in myCharArray)
{
char Char1;
if (Char.IsDigit(x)) Char1 = 'A';
if (Char.IsLetter(x)) Char1 = 'B';

s += Char1;

}

This will *not* compile with the same error: you try to *read* a
variable (Char1) that possibly has not been assigned a value (*you* may
know that this routine will only get Digits or Letters, but the
compiler doesn't)


Hans Kesting
 
RayLopez99 said:
I doubt it Goran, but thanks for your answer. You can have an
unassigned variable int jay; for example, last I checked (let me check
now... yes, you just get a warning: "variable 'jay' is declared but
never used" but it compiles).

RL
Click to expand...

I never said that you can't have an unassigned variable, I said that you
can't _use_ an unassigned variable.

Before doubting something, you should make sure that you at least read
it properly...
 
This will *not* compile with the same error: you try to *read* a
variable (Char1) that possibly has not been assigned a value (*you* may
know that this routine will only get Digits or Letters, but the
compiler doesn't)

Hans Kesting
Click to expand...

Thanks Hans. Essentially you are doing a workaround as in my "dummy
variable" assignment. I don't really see the difference. Thanks for
your input.

RL
 
Back
Top