DBHelper.GetConnection

  • Thread starter Thread starter mc
  • Start date Start date
M

mc

I have a class (shown below) used to save me retyping the Connection
initialization code and other handy things, the Code Review tool in Ms
Visual Studio is telling me that the I should "Change 'GetConnection' to
a property if appropriate"

Is it "appropriate"?

TIA


Mike

public sealed class DBHelper
{
private DBHelper() { }

public static SqlConnection GetConnection()
{
SqlConnection conn = new
SqlConnection(ConfigurationManager.ConnectionStrings["connStr"].ConnectionString);
conn.Open();
return conn;
}
 
mc said:
I have a class (shown below) used to save me retyping the Connection
initialization code and other handy things, the Code Review tool in Ms
Visual Studio is telling me that the I should "Change 'GetConnection' to a
property if appropriate"

Is it "appropriate"?
Click to expand...

No. You should not. This should be a method instead of a property because
there is non-trivial operation inside the method.

The presence of "Get" in the name suggests a trival java-style "getter",
which should be replaced with a property. This is really a factory method,
not a getter. Perhaps "OpenConnection" or "Connect" might be more
appropriate names.

David
 
Yes, I agree. This is a factory method and should not use a property.

Kevin Yu
Microsoft Online Community Support

==================================================
Get notification to my posts through email? Please refer to
http://msdn.microsoft.com/subscriptions/managednewsgroups/default.aspx#notif
ications.
Note: The MSDN Managed Newsgroup support offering is for non-urgent issues
where an initial response from the community or a Microsoft Support
Engineer within 1 business day is acceptable. Please note that each follow
up response may take approximately 2 business days as the support
professional working with you may need further investigation to reach the
most efficient resolution. The offering is not appropriate for situations
that require urgent, real-time or phone-based interactions or complex
project analysis and dump analysis issues. Issues of this nature are best
handled working with a dedicated Microsoft Support Engineer by contacting
Microsoft Customer Support Services (CSS) at
http://msdn.microsoft.com/subscriptions/support/default.aspx.
==================================================

(This posting is provided "AS IS", with no warranties, and confers no
rights.)
 
Back
Top