Create a complex type from Linq-to-XML

[C.]

Hi,

I have a User object with two properties, ID and Name

I have an XML file that looks like this:

<?xml version="1.0" encoding="utf-8" ?>
<Users>
<User>
<ID>4</ID>
<Name>Paul</Name>
</User>
<User>
<ID>3</ID>
<Name>John</Name>
</User>
<User>
<ID>2</ID>
<Name>George</Name>
</User>
<User>
<ID>1</ID>
<Name>Ringo</Name>
</User>
</Users>

I have a function that retrieves all users from the file and returns a
List<User>. Is this the best way to do this?

public List<User> GetUsers()
{
XDocument doc = XDocument.Load("path/to/file/xml");

var Users = from user in doc.Descendants("User")
select new
{
ID = user.Element("ID").Value,
Name = user.Element("Name").Value
};

List<User> UserList = new List<User>();

foreach (var currUser in Users)
{
UserList.Add(new User(Convert.ToInt32(currUser.ID),
currUser.Name));
}
return UserList;
}

 

[sloan]

You can look here:
http://blogs.msdn.com/xmlteam/archive/2007/03/24/streaming-with-linq-to-xml-part-2.aspx

Which might be a little more efficient with an XmlReader (instead of a fully
loaded Dom).

............

If you go with that approach, post your code example (using your sample xml)
so others might find a good solution. (Years down the road when they're
googling for answers).

............

 

[Mr. Arnold]

Hi,

I have a User object with two properties, ID and Name

I have an XML file that looks like this:

<?xml version="1.0" encoding="utf-8" ?>
<Users>
<User>
<ID>4</ID>
<Name>Paul</Name>
</User>
<User>
<ID>3</ID>
<Name>John</Name>
</User>
<User>
<ID>2</ID>
<Name>George</Name>
</User>
<User>
<ID>1</ID>
<Name>Ringo</Name>
</User>
</Users>

I have a function that retrieves all users from the file and returns a
List<User>. Is this the best way to do this?

public List<User> GetUsers()
{
XDocument doc = XDocument.Load("path/to/file/xml");

var Users = from user in doc.Descendants("User")
select new
{
ID = user.Element("ID").Value,
Name = user.Element("Name").Value
};

List<User> UserList = new List<User>();

foreach (var currUser in Users)
{
UserList.Add(new User(Convert.ToInt32(currUser.ID),
currUser.Name));
}
return UserList;
}
.

var users = new List<Users>();

users = (from user in doc.Descendants("User")
select new
{
ID = user.Element("ID").Value,
Name = user.Element("Name").Value
}).ToList();

return users;

return (from user in doc.Descendants("User")
select new
{
ID = user.Element("ID").Value,
Name = user.Element("Name").Value
}).ToList();