C# - C sharp - String to decimal, decimal point disappears!

  • Thread starter Thread starter BA
  • Start date Start date
B

BA

Hello,

I have a string with a price in: "$14.95"

I need to get it into a decimal.

So I regex 'd the string and dumped the $. Debug mon shows a clean string
"14.95"

Then I do a System.Convert.ToDecimal on the clean string and the output
becomes: 1495

What gives!? I've tried a variety of workarounds but nothing works. How
can I format it for 2 decimal places or perform the convert in a way I am
not aware of?

Thanks alot!
 
Peter Mancini said:
Show us the code. Copy it from your program. Might be a syntax issue.
Click to expand...

Thanks for the response, here is the code (cutout try catch for ease of
reading, other funciton just returns the decimal:


public decimal Lookup(string ISBN)
{
string CleanPrice;
decimal decCleanPrice;

System.Diagnostics.Trace.WriteLine("AmazonWebServiceDLL:AmazonLookupAdapter
ENTER");

//Create Instance of Proxy Class
SService as1 = new SService ();

SService.lookup = ISBN;

CleanPrice = as1.AsinSearchRequest(asin);

CleanPrice =
System.Text.RegularExpressions.Regex.Replace(pi.Details[0].OurPrice,System.Text.RegularExpressions.Regex.Escape("$"),
"");
System.Diagnostics.Trace.WriteLine("price: " + CleanPrice);

decCleanPrice = ConvertStringDecimal(CleanPrice.ToString());

System.Diagnostics.Trace.WriteLine(System.Convert.ToString(decCleanPrice));
System.Diagnostics.Trace.WriteLine("EXIT");

return decCleanPrice;
}



internal decimal ConvertStringDecimal(string stringVal)
{
decimal decimalVal;

try
{
decimalVal = System.Convert.ToDecimal(stringVal);
System.Diagnostics.Trace.WriteLine("The string as a decimal is {0}.",
decimalVal.ToString());
return decimalVal;

}
catch (System.OverflowException)
{
System.Diagnostics.Trace.WriteLine("The conversion from string to
decimal overflowed.");
return 0;
}
catch (System.FormatException)
{
System.Diagnostics.Trace.WriteLine("The string is not formatted as a
decimal.");
return 0;
}
catch (System.ArgumentNullException)
{
System.Diagnostics.Trace.WriteLine("The string is null.");
return 0;
}
}

}
}

Thanks again
 
I don't see the problem. The output I get is 14.95.

-sb

// Method simplified for clarity
internal decimal ConvertStringToDecimal(string stringVal)
{
try
{
return System.Convert.ToDecimal(stringVal.TrimStart('$')); // remove
the "$", convert it to a decimal, then return it
}
catch (Exception ex)
{
System.Diagnostics.Trace.WriteLine(ex.Message);
}
return 0;
}





BA said:
Peter Mancini said:
Show us the code. Copy it from your program. Might be a syntax issue.
Click to expand...

Thanks for the response, here is the code (cutout try catch for ease of
reading, other funciton just returns the decimal:


public decimal Lookup(string ISBN)
{
string CleanPrice;
decimal decCleanPrice;


System.Diagnostics.Trace.WriteLine("AmazonWebServiceDLL:AmazonLookupAdapter
ENTER");

//Create Instance of Proxy Class
SService as1 = new SService ();

SService.lookup = ISBN;

CleanPrice = as1.AsinSearchRequest(asin);

CleanPrice =
System.Text.RegularExpressions.Regex.Replace(pi.Details[0].OurPrice,System.Text.RegularExpressions.Regex.Escape("$"),
"");
System.Diagnostics.Trace.WriteLine("price: " + CleanPrice);

decCleanPrice = ConvertStringDecimal(CleanPrice.ToString());


System.Diagnostics.Trace.WriteLine(System.Convert.ToString(decCleanPrice));
System.Diagnostics.Trace.WriteLine("EXIT");

return decCleanPrice;
}



internal decimal ConvertStringDecimal(string stringVal)
{
decimal decimalVal;

try
{
decimalVal = System.Convert.ToDecimal(stringVal);
System.Diagnostics.Trace.WriteLine("The string as a decimal is {0}.",
decimalVal.ToString());
return decimalVal;

}
catch (System.OverflowException)
{
System.Diagnostics.Trace.WriteLine("The conversion from string to
decimal overflowed.");
return 0;
}
catch (System.FormatException)
{
System.Diagnostics.Trace.WriteLine("The string is not formatted as a
decimal.");
return 0;
}
catch (System.ArgumentNullException)
{
System.Diagnostics.Trace.WriteLine("The string is null.");
return 0;
}
}

}
}

Thanks again
Click to expand...
 
Does your system use the . (dot) symbol as the decimal symbol? Some european
country use the comma (,) as decimal symbol, and dot (.) as the digit
grouping symbol. If you're in the latter case, the conversion will ignore
the dot and treat the "14.95" as "1495". You can solve this by using
specific CultureInfo object to specify the locale that you want to use.

Hope it helps.

-- Ricky Lee
============================================
^o^ "When all doors are closed, God will open a Windows" ^o^
============================================

BA said:
Peter Mancini said:
Show us the code. Copy it from your program. Might be a syntax issue.
Click to expand...

Thanks for the response, here is the code (cutout try catch for ease of
reading, other funciton just returns the decimal:


public decimal Lookup(string ISBN)
{
string CleanPrice;
decimal decCleanPrice;

System.Diagnostics.Trace.WriteLine("AmazonWebServiceDLL:AmazonLookupAdapter
ENTER");

//Create Instance of Proxy Class
SService as1 = new SService ();

SService.lookup = ISBN;

CleanPrice = as1.AsinSearchRequest(asin);

CleanPrice =
System.Text.RegularExpressions.Regex.Replace(pi.Details[0].OurPrice,System.T
ext.RegularExpressions.Regex.Escape("$"),
"");
System.Diagnostics.Trace.WriteLine("price: " + CleanPrice);

decCleanPrice = ConvertStringDecimal(CleanPrice.ToString());

System.Diagnostics.Trace.WriteLine(System.Convert.ToString(decCleanPrice));
System.Diagnostics.Trace.WriteLine("EXIT");

return decCleanPrice;
}



internal decimal ConvertStringDecimal(string stringVal)
{
decimal decimalVal;

try
{
decimalVal = System.Convert.ToDecimal(stringVal);
System.Diagnostics.Trace.WriteLine("The string as a decimal is {0}.",
decimalVal.ToString());
return decimalVal;

}
catch (System.OverflowException)
{
System.Diagnostics.Trace.WriteLine("The conversion from string to
decimal overflowed.");
return 0;
}
catch (System.FormatException)
{
System.Diagnostics.Trace.WriteLine("The string is not formatted as a
decimal.");
return 0;
}
catch (System.ArgumentNullException)
{
System.Diagnostics.Trace.WriteLine("The string is null.");
return 0;
}
}

}
}

Thanks again
Click to expand...
 
Try
System.Globalization.NumberFormatInfo nfi = new
System.Globalization.NumberFormatInfo();
nfi.NumberGroupSeparator = ",";
string s = "14.95";
decimal value = decimal.Parse(s, nfi);


--
Regards,
Dennis JD Myrén
Oslo Kodebureau
Ricky Lee said:
Does your system use the . (dot) symbol as the decimal symbol? Some
european
country use the comma (,) as decimal symbol, and dot (.) as the digit
grouping symbol. If you're in the latter case, the conversion will ignore
the dot and treat the "14.95" as "1495". You can solve this by using
specific CultureInfo object to specify the locale that you want to use.

Hope it helps.

-- Ricky Lee
============================================
^o^ "When all doors are closed, God will open a Windows" ^o^
============================================

BA said:
Peter Mancini said:
Show us the code. Copy it from your program. Might be a syntax issue.
Click to expand...

Thanks for the response, here is the code (cutout try catch for ease of
reading, other funciton just returns the decimal:

code>>>>>>>>>>>>>>>>
Click to expand...

public decimal Lookup(string ISBN)
{
string CleanPrice;
decimal decCleanPrice;

System.Diagnostics.Trace.WriteLine("AmazonWebServiceDLL:AmazonLookupAdapter
ENTER");

//Create Instance of Proxy Class
SService as1 = new SService ();

SService.lookup = ISBN;

CleanPrice = as1.AsinSearchRequest(asin);

CleanPrice =
System.Text.RegularExpressions.Regex.Replace(pi.Details[0].OurPrice,System.T
ext.RegularExpressions.Regex.Escape("$"),
"");
System.Diagnostics.Trace.WriteLine("price: " + CleanPrice);

decCleanPrice = ConvertStringDecimal(CleanPrice.ToString());

System.Diagnostics.Trace.WriteLine(System.Convert.ToString(decCleanPrice));
System.Diagnostics.Trace.WriteLine("EXIT");

return decCleanPrice;
}



internal decimal ConvertStringDecimal(string stringVal)
{
decimal decimalVal;

try
{
decimalVal = System.Convert.ToDecimal(stringVal);
System.Diagnostics.Trace.WriteLine("The string as a decimal is {0}.",
decimalVal.ToString());
return decimalVal;

}
catch (System.OverflowException)
{
System.Diagnostics.Trace.WriteLine("The conversion from string to
decimal overflowed.");
return 0;
}
catch (System.FormatException)
{
System.Diagnostics.Trace.WriteLine("The string is not formatted as a
decimal.");
return 0;
}
catch (System.ArgumentNullException)
{
System.Diagnostics.Trace.WriteLine("The string is null.");
return 0;
}
}

}
}
code>>>>>>>>>>>>>>>>
Click to expand...

Thanks again
Click to expand...
Click to expand...
 
It has to do with the culture of the running thread. See the docs for
System.Threading.Thread.CurrentCulture, System.Globalization.CultureInfo and
System.Globalization.NumberFormatInfo. The property NumberDecimalSeparator
of the class System.Globalization.NumberFormatInfo specifies the decimal
separator to be used for parsing etc.

You can always change the culture for your thread if you wish.

Regards, Jakob.


BA said:
Peter Mancini said:
Show us the code. Copy it from your program. Might be a syntax issue.
Click to expand...

Thanks for the response, here is the code (cutout try catch for ease of
reading, other funciton just returns the decimal:


public decimal Lookup(string ISBN)
{
string CleanPrice;
decimal decCleanPrice;

System.Diagnostics.Trace.WriteLine("AmazonWebServiceDLL:AmazonLookupAdapter
ENTER");

//Create Instance of Proxy Class
SService as1 = new SService ();

SService.lookup = ISBN;

CleanPrice = as1.AsinSearchRequest(asin);

CleanPrice =
System.Text.RegularExpressions.Regex.Replace(pi.Details[0].OurPrice,System.Text.RegularExpressions.Regex.Escape("$"),
"");
System.Diagnostics.Trace.WriteLine("price: " + CleanPrice);

decCleanPrice = ConvertStringDecimal(CleanPrice.ToString());

System.Diagnostics.Trace.WriteLine(System.Convert.ToString(decCleanPrice));
System.Diagnostics.Trace.WriteLine("EXIT");

return decCleanPrice;
}



internal decimal ConvertStringDecimal(string stringVal)
{
decimal decimalVal;

try
{
decimalVal = System.Convert.ToDecimal(stringVal);
System.Diagnostics.Trace.WriteLine("The string as a decimal is {0}.",
decimalVal.ToString());
return decimalVal;

}
catch (System.OverflowException)
{
System.Diagnostics.Trace.WriteLine("The conversion from string to
decimal overflowed.");
return 0;
}
catch (System.FormatException)
{
System.Diagnostics.Trace.WriteLine("The string is not formatted as a
decimal.");
return 0;
}
catch (System.ArgumentNullException)
{
System.Diagnostics.Trace.WriteLine("The string is null.");
return 0;
}
}

}
}

Thanks again
Click to expand...
 
Back
Top