Best way to clear contents of a stringbuilder object

  • Thread starter Thread starter moondaddy
  • Start date Start date
M

moondaddy

Using c# 3.5, what's the best way to remove the contents of a stringbuilder
object? I was using this code:

sb.Remove(1, sb.Length - 1);

but when it had 9 carriage returns in it like this:
"\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n"

I got the error:
System.ArgumentOutOfRangeException: Length cannot be less than zero.
Parameter name: length at System.Text.StringBuilder.Remove(Int32 startIndex,
Int32 length)

You would think there would be a simple Clear() method.

Thanks.
 
Using c# 3.5, what's the best way to remove the contents of a stringbuilder
object? I was using this code:

sb.Remove(1, sb.Length - 1);

but when it had 9 carriage returns in it like this:
"\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n"

I got the error:
System.ArgumentOutOfRangeException: Length cannot be less than zero.
Parameter name: length at System.Text.StringBuilder.Remove(Int32 startIndex,
Int32 length)

You would think there would be a simple Clear() method.

Thanks.
Click to expand...

If you want to remove everything, set Length = 0.

Your call to Remove should have left the first character, but would
give an error if there were no characters in the stringbuilder.
 
moondaddy said:
Using c# 3.5, what's the best way to remove the contents of a stringbuilder
object? I was using this code:

sb.Remove(1, sb.Length - 1);

but when it had 9 carriage returns in it like this:
"\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n"

I got the error:
System.ArgumentOutOfRangeException: Length cannot be less than zero.
Parameter name: length at System.Text.StringBuilder.Remove(Int32 startIndex,
Int32 length)

You would think there would be a simple Clear() method.
Click to expand...

Well, aside from the response from Jack, why don't you just create a
new StringBuilder?
 
Thanks Jon and Jack.

I thought about that, but figured there would be a more efficient way to
clear the content rather than creating a whole new object. My guess is that
Jack's suggestion will consume less resources than creating a new
stringbuilder each time since it will be used in an iteration.
 
moondaddy said:
I thought about that, but figured there would be a more efficient way to
clear the content rather than creating a whole new object. My guess is that
Jack's suggestion will consume less resources than creating a new
stringbuilder each time since it will be used in an iteration.
Click to expand...

The important thing is that creating a new StringBuilder for each
iteration is simpler to understand. Unless this turns into a
performance bottleneck, you should use the simplest reasonable code and
not worry about micro-optimising. Clearing and reusing a StringBuilder
definitely counts as micro-optimisation - and it may well go wrong, as
the StringBuilder will end up in gen1 or gen2, rather than being
garbage collected quickly.
 
Jon,

I am more and more happy when I see this kind of messages from you.
The important thing is that creating a new StringBuilder for each
iteration is simpler to understand. Unless this turns into a
performance bottleneck, you should use the simplest reasonable code and
not worry about micro-optimising. Clearing and reusing a StringBuilder
definitely counts as micro-optimisation - and it may well go wrong, as
the StringBuilder will end up in gen1 or gen2, rather than being
garbage collected quickly.
Click to expand...
Absolutely my idea too.

Have a look at my reply too.

:-)

Cor
 
Moondaddy,

The simplest method is in my idea to let it go out of scope.

Cor
 
Back
Top